fastmri-reproducible-benchmark icon indicating copy to clipboard operation
fastmri-reproducible-benchmark copied to clipboard

Published 20 hours ago • verified publisher icon zaccharieramzi

Misplaced compound_l1_mssim_loss

Open Daval-G opened this issue 3 years ago • 1 comments

The function named compound_l1_mssim_loss is currently defined in models/training/compile.py which is not really intuitive. I would expect it to be defined along with other loss functions at evaluate.metrics.tf_metrics.py or simply in evaluate.metrics.

Daval-G avatar Aug 26 '21 09:08 Daval-G

Good point. I would rather have a new file, losses.py where we could define this, because the compound mssim is not really a metric per se.

zaccharieramzi avatar Aug 26 '21 11:08 zaccharieramzi