Stamatis Zampetakis

Results 109 comments of Stamatis Zampetakis

Cool, many thanks for working on this! Once you have it ready, let me know I can test the new class with Hive to see what it gives.

> Hi @zabetak will this change break any the backwards compatibility with older kafka version? @akshat0395 Any code that relies on reflection and internal classes is unlike to be backward...

I forgot about this issue. I will take a a look now.

I added two commits to sync with master and resolve conflicts. If it comes green I will merge the PR tomorrow.

Thanks for the reviews @kasakrisz and @asolimando !

@devaspatikrishnatri By removing the json-path, I was thinking actually excluding it from calcite and not having it at all in the Hive dependency tree.

@devaspatikrishnatri The way it seems is that we have a problem in Calcite and by pinning the dependency in Hive we are making it a Hive problem as well. Probably...

The end to end approach (2.) seems a bit of an overkill. Even if the NPE is caught and logged you still have some missing entries (e.g., `queryPlan`) in the...

Hey @deniskuzZ , I have nothing against merging the patch especially if you already did a review. As I mentioned under the ticket, the non-CBO path is not recommended and...