mib2zabbix
mib2zabbix copied to clipboard
Add support for Zabbix V2.4 template schema
- Add Zabbix V2.4 template schema
- LLD Index move to the discovery level
- Remove index item in the prototype creation for LLD
Hey Steven, I really want to accept this PR because it's a great feature and you've done a good job. Unfortunately your commits are still filled with line-break removals. In particular, this messes with Perl POD doc generation. Have a look at https://github.com/cavaliercoder/mib2zabbix/pull/5/files and you will see all the blank red lines.
It might be worth rewinding your changes to succinctly apply the required code changes only. Also beware that your code editor might be applying some formatting of its own design.
If I get a chance later, I'll merge your PR and unwind the line breaks for you.
I can see the blank red lines, but when I edit it is not there anymore, could it be extra carriage return in there somewhere?
On 24 January 2017 at 11:10, Ryan Armstrong [email protected] wrote:
Hey Steven, I really want to accept this PR because it's a great feature and you've done a good job. Unfortunately your commits are still filled with line-break removals. In particular, this messes with Perl POD doc generation. Have a look at https://github.com/ cavaliercoder/mib2zabbix/pull/5/files and you will see all the blank red lines.
It might be worth rewinding your changes to succinctly apply the required code changes only. Also beware that your code editor might be applying some formatting of its own design.
If I get a chance later, I'll merge your PR and unwind the line breaks for you.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cavaliercoder/mib2zabbix/pull/5#issuecomment-274659727, or mute the thread https://github.com/notifications/unsubscribe-auth/ADzGCc6Gy3na0s3jI1sYIw6xsvkeH8sRks5rVUFvgaJpZM4Jrpj6 .
-- Steven Yu
"And you will know the truth, and the truth will set you free", John 8:32 "你們必定認識真理,真理必定使你們自由", 約翰福音 8:32