jsonlint icon indicating copy to clipboard operation
jsonlint copied to clipboard

Add "file" and "system" packages to depedencies

Open rogeriopvl opened this issue 8 years ago • 5 comments

This fixes #57

@zaach jsonlint is kind of abandoned. Let me know if you need help maintaining this project. I would be glad to help out :)

rogeriopvl avatar Oct 11 '15 01:10 rogeriopvl

file and system... wait a sec, are those from the old support of Narwhal in jison?? Um, it might be time to regenerate the parser.

zaach avatar Oct 13 '15 00:10 zaach

It might also be time to add contributors :) (no sarcasm intended)

ronkorving avatar Nov 25 '15 02:11 ronkorving

Please merge this pull request!

evaliyev avatar May 30 '18 09:05 evaliyev

Why do the packages file and system have to be added to the dependencies of this package? And not just to "devDependencies", but to "dependencies". As such they would get installed by anyon, including people, who do not work with browserify. Should not those projects, which use browserify, depend on those two packages in their package.json files?

prantlf avatar May 19 '19 05:05 prantlf

system and file are used in lib/jsonlint.js in the node environment at runtime (https://github.com/zaach/jsonlint/blob/master/lib/jsonlint.js#L430 and https://github.com/zaach/jsonlint/blob/master/lib/jsonlint.js#L424). I would leave them in dependencies.

evaliyev avatar May 19 '19 09:05 evaliyev