za3k
Treat a return code 0 as success
I always get this error when using qr-backup even though the generated PDF is fully functional and the SHAs match:
ERROR: !!Automatic digital restore verification FAILED (self-test). This indicates a bug in qr-backup. Please report this to the author at https://github.com/za3k/qr-backup/issues
I am a bit puzzled by this, but I guess that the exit code is interpreted incorrectly here. 0 indicates success, so the boolean should be set like in this PR.
Thanks.
Yes, restores often fail with a false positive. It's a bug in zbarimg (see https://github.com/za3k/qr-backup/issues/9 ) which I would love someone to thoroughly fix
Also they fail to even run on debian, because of ghostscript/PDF security issues, but that's unrelated.
BTW I haven't forgotten this. It's just that tests are failing on master so I need to fix that first.
I'm going to disable self-test as a whole for the time being. It was a good idea in theory, but it's a bad user experience in the current state to get constant false positives.
It was a mistake that I left it on even a tenth this long. I think I had the vague idea that it would get me/others to fix zbarimg's reliability, but that logic was clearly wrong (and was not user-centric enough)
(And given that I'm going to disable self-test for users, obviously we really want unit tests to work on the maintainance end)