ImageOnMap icon indicating copy to clipboard operation
ImageOnMap copied to clipboard

Dupe

Open DarkWolfZachary opened this issue 3 years ago • 7 comments

https://www.youtube.com/watch?v=IUYLySgDsHM

DarkWolfZachary avatar Feb 10 '22 04:02 DarkWolfZachary

Please fix this, this seems to work on 1.18.1 on the latest version of the plugin, oof.

hirata-estate avatar Feb 20 '22 14:02 hirata-estate

Hi, we won't have time to fix that in the short time, but feel free to contribute, this is an open source software!

AmauryCarrade avatar Feb 21 '22 18:02 AmauryCarrade

I fully understand that, but perhaps as a short-term fix, could the item be changed to redstone until this bug is fully fixed? That way the damage is mostly contained and barriers, being an illegal item, are not distrubuted to playerbases by dupers. I unfortunately don't know any java so I'm not sure as to how to do this myself...

hirata-estate avatar Feb 21 '22 23:02 hirata-estate

For others who have this on their servers, you can negate the - imageonmap.rename permission temporarily to circumvent the dupe. (while still letting players manage maps)

hirata-estate avatar Feb 21 '22 23:02 hirata-estate

I fully understand that, but perhaps as a short-term fix, could the item be changed to redstone until this bug is fully fixed? That way the damage is mostly contained and barriers, being an illegal item, are not distrubuted to playerbases by dupers. I unfortunately don't know any java so I'm not sure as to how to do this myself...

Feel free to open a PR, I'll merge it happily :)

https://github.com/zDevelopers/ImageOnMap/blob/243cfc24022cc670230d2c349d4c9cf1fe1b43b7/src/main/java/fr/moribus/imageonmap/gui/MapDetailGui.java#L176

AmauryCarrade avatar Feb 22 '22 15:02 AmauryCarrade

why not just commit it yourself?

man-of-eel avatar Mar 06 '22 16:03 man-of-eel

i had the same problem and i found a temporary fix for it, you just remove the permission to use /maps command, if the player cant access the GUI using this command; they cant get illegal items. i used Luckperm for that but you can use what evet you want.

fathe4wiin avatar Apr 02 '23 09:04 fathe4wiin