ImageOnMap icon indicating copy to clipboard operation
ImageOnMap copied to clipboard

[UNIQUE] 1.17 support

Open AmauryCarrade opened this issue 4 years ago • 38 comments

This is a ticket for every request related to 1.17 support.


  • [ ] Splatter maps not working correctly Whenever i make a make using /tomap it creates it fine but if it is over 1x1 and i try to put it on a item frame it doesnt fill all of them and when i take it back it disappears. This only started happening after i upgraded to 1.17

    • #192
    • #194
    • #195
  • [ ] Rendering looks slow

    • #195
  • [ ] Cannot create maps Map rendering failed: java.lang.NullPointerException: Cannot read field "mapView" because "worldmap" is null

    • #199
  • [ ] Unable to get splatter map attribute on item (because NMS classes are not found)

    • #200 (trace)
  • [ ] Unable to rename map (because NMS classes are not found)

    • #201
  • [ ] After restarting the server, the maps dont show images

    • #203 (no details)
    • #210 (More details provided)

Add your 1.17 compatibility requests in this issue. Thanks!

AmauryCarrade avatar Jun 22 '21 12:06 AmauryCarrade

Sorry for not writting in the right place, do you know a way to the fix my problem? Thanks for the quick response before!

Vorald avatar Jun 23 '21 23:06 Vorald

First of all, try to use the latest Spigot/Paper possible. Some users reported improvements with the latest builds. But we have to update ImageOnMap itself because some internals changed, so for your problem, you'll probably have to wait until we release a 1.17-compatible version. Work is in progress but it's on our free time so it's… when possible :) .

And, you're welcome!

AmauryCarrade avatar Jun 23 '21 23:06 AmauryCarrade

First of all, try to use the latest Spigot/Paper possible. Some users reported improvements with the latest builds. But we have to update ImageOnMap itself because some internals changed, so for your problem, you'll probably have to wait until we release a 1.17-compatible version. Work is in progress but it's on our free time so it's… when possible :) .

And, you're welcome!

Thanks!

Vorald avatar Jun 23 '21 23:06 Vorald

waiting.. patiently.. :(

Zoro-6191 avatar Jun 29 '21 06:06 Zoro-6191

me too when wil the 1.17 come out will it work if we render the source on java 16?

dimethro avatar Jul 06 '21 03:07 dimethro

zDev I apologize for this, since you don't supposed to be working on the plugin, I'll leave a link to a separate plugin for people who can't wait for it to come out

Zoro-6191 avatar Jul 06 '21 09:07 Zoro-6191

Any update here?

Aurelien30000 avatar Aug 04 '21 10:08 Aurelien30000

In progress but I still have some anoying bugs to fix, such as this one https://cdn.discordapp.com/attachments/722920026574684211/860821198035877918/unknown.png.

Vlammar avatar Aug 04 '21 13:08 Vlammar

Hello, Is ImageOnMap mostly ready for 1.17 ? I would like to use it and I would be happy to help if needed

Aqueuse avatar Nov 12 '21 11:11 Aqueuse

To have an idea on what's left see #219 and https://github.com/zDevelopers/QuartzLib/pull/80

Vlammar avatar Nov 12 '21 12:11 Vlammar

Waiting for the PR review. once done I will lock this and subsequent issues

Vlammar avatar Nov 13 '21 23:11 Vlammar

@Vlammar I noticed you merged https://github.com/zDevelopers/ImageOnMap/pull/219, is there anything else that needs to be done?

srnyx avatar Nov 17 '21 21:11 srnyx

@srnyx @Aqueuse https://github.com/zDevelopers/ImageOnMap/releases/tag/v4.2.0 Still waiting for the final release but here is an actual pre release from the lastest indev build. If you want to build it you have to use the update/1.17 branch of quartzlib and change the pom.xml of IoM to make sure you use "0.0.5-SNAPSHOT" of QL. Don't hesitate to report me any issues you may find

Vlammar avatar Nov 17 '21 22:11 Vlammar

use the update/1.17 branch of quartzlib

How do I do this? I can't seem to build it.

change the pom.xml of IoM to make sure you use "0.0.5-SNAPSHOT" of QL.

How do I do this as well? Is it not already changed in the pre-release JAR?

srnyx avatar Nov 17 '21 22:11 srnyx

You can use the IoM4.2.0.jar directly. I was only giving the steps to build it. We haven't release yet QL 0.0.5 that's why if you try to build IoM 4.2.0 this won't works

Vlammar avatar Nov 17 '21 22:11 Vlammar

You can use the IoM4.2.0.jar directly. I was only giving the steps to build it. We haven't release yet QL 0.0.5 that's why if you try to build IoM 4.2.0 this won't works

Ohhhhhh! Alright, thank you šŸ˜„

srnyx avatar Nov 17 '21 22:11 srnyx

Don't hesitate to report me any issues you may find

image

srnyx avatar Nov 18 '21 20:11 srnyx

You have any output in the console ? @srnyx What minecraft version are you running ? (and paper/spigot?)

Vlammar avatar Nov 18 '21 20:11 Vlammar

You have any output in the console ?

No

What minecraft version are you running ? (and paper/spigot?)

Purpur 1.17.1

srnyx avatar Nov 18 '21 21:11 srnyx

@Vlammar images don't work at all: https://paste.srnyx.xyz/zovoqoduwe.md The files aren't being generated in the maps folder. When I use the command, I get the image, I can place it in an item frame, but when I remove them from the item frame and then place it back it, it gets deleted.

srnyx avatar Nov 18 '21 23:11 srnyx

@srnyx don't know how I have done it but the version uploaded was done with old indev code despite being builded after the merge with #219 . That should work fine right now

Vlammar avatar Nov 19 '21 00:11 Vlammar

@Vlammar images don't work at all: https://paste.srnyx.xyz/zovoqoduwe.md The files aren't being generated in the maps folder. When I use the command, I get the image, I can place it in an item frame, but when I remove them from the item frame and then place it back it, it gets deleted.

@Vlammar the images folder isn't being created, hence the error he's experiencing. If you manually create a images folder in the directory, the plugin works fine.

brysondev avatar Nov 19 '21 02:11 brysondev

@Vlammar images don't work at all: paste.srnyx.xyz/zovoqoduwe.md The files aren't being generated in the maps folder. When I use the command, I get the image, I can place it in an item frame, but when I remove them from the item frame and then place it back it, it gets deleted.

@Vlammar the images folder isn't being created, hence the error he's experiencing. If you manually create a images folder in the directory, the plugin works fine.

I think it's called maps, which was being generated, just the image files themselves weren't. Updating the JAR file fixed it.

srnyx avatar Nov 19 '21 02:11 srnyx

I think it's called maps, which was being generated, just the image files themselves weren't. Updating the JAR file fixed it.

Scratch this, @brysondev was right, the images folder isn't being generated. Manually creating the images folder fixes it.

srnyx avatar Nov 19 '21 22:11 srnyx

Now we need 1.18 support šŸ˜”

srnyx avatar Dec 01 '21 00:12 srnyx

Is there any solution for splatter maps not working? All I see are the threads that point to here but this doesn't have a definite answer

plopilpy avatar Dec 08 '21 04:12 plopilpy

Is there any solution for splatter maps not working? All I see are the threads that point to here but this doesn't have a definite answer

You need to be more specific about your issue. As the thread suggests they are working on fixing the issues stated above. What error are you getting?

brysondev avatar Dec 08 '21 11:12 brysondev

I'm not getting any errors. I follow the steps exactly as described, and it doesn't work.

plopilpy avatar Dec 10 '21 01:12 plopilpy

I'm not getting any errors. I follow the steps exactly as described, and it doesn't work.

Maybe because we are working on it and there is a pre release https://github.com/zDevelopers/ImageOnMap/releases/tag/v4.2.0

Vlammar avatar Dec 10 '21 01:12 Vlammar

1.17 support is finally here with 1.18 suport. see the 4.2.1 of IoM https://github.com/zDevelopers/ImageOnMap/releases/tag/v4.2.1

Vlammar avatar Dec 13 '21 15:12 Vlammar