Zac Nowicki

Results 101 comments of Zac Nowicki

#601 set the default to `:large` again. We can revert this whenever someone has the the capability & time to investigate this issue with accuracy, and present improved benchmarks.

With #680, the critical section of the gateway's performance is increased. For reference: A bot in the community on approx. 600 guilds startup time was reduced to about 26% of...

Please don't add further unrelated changes to this PR.

Correct, only the "top level" ones are the values that can be passed to the bitmask. For the library as a whole, we won't be changing `Server` to `Guild` anytime...

Moreover, adding compatibility for guild-* naming is drastically easier later, than it is to start thinking about guild-* now.

~~Sorry, there's a lot here - could you point out the code example that you're unsure about?~~ Resolved in chat

I've updated this with some improvements to make adoption much smoother. - MiddlewareBot is removed. After reviewing this again, `MiddlewareBot` is essentially just an `EventContainer`. It has *no actual "Bot"*...

The next change (665efb6) replaces the placeholder `lambda` stock middleware with a thin `MessageFilter` class that implements each of the attribute matchers as individual methods. `call` determines which matcher to...

I've squashed the development history on this now that I believe this has reached a solid point enough to be merged as-is, allowing for further improvements to come from myself...

Since this PR is post-3.3, it will depend on #487 which ups our `TargetRubyVersion` to 2.3 so we can use squiggly heredocs for the nice multiline exception message I have...