aws-security-toolbox icon indicating copy to clipboard operation
aws-security-toolbox copied to clipboard

Nitpick: Use Releases and curl instead of git clone

Open zbruhnke opened this issue 5 years ago • 1 comments

https://github.com/z0ph/aws-security-toolbox/blob/30fa2473065bac6c546391e39ee55b02c00cb9e8/Dockerfile#L36

Just adding this hear as a suggestion mostly AFAICT there is no reason you need git installed here other than the fact that you're cloning entire repos to install them.

However Github has a "release" feature and all the repos you're downloading utilize them. This would allow you to save installing git, just do this with curl and have a lot less work to do installing and building this image.

I also think it would make it cleaner especially because Github makes it easy to package releases for specific OS's so you could only download a .deb file if they are to make one available at some point.

Overall kudos on putting something together and trying to be useful to the community.

zbruhnke avatar Dec 31 '19 17:12 zbruhnke

Thanks for your useful feedback, will add this in the next release. Seems legit :)

z0ph avatar Jan 01 '20 16:01 z0ph