dependent-issues icon indicating copy to clipboard operation
dependent-issues copied to clipboard

chore: change depends status from pending to failure

Open johncardiologs opened this issue 1 year ago • 3 comments

Description

Changes the status of the blocked PR status from pending to failure when a PR is marked as dependent.

Motivation

This is an opinionated change, but I find that the orange pending status is not as appropriate as a failure notifier, in the merge status box. I find that most CI tools (e.g. jenkins) will mark the PR with the red failure notifier if the PR should not be merged. The orange pending notifier is usually reserved to ongoing CI runs and suggests that we don't yet know the outcome of the merge status.

Not particularly attached, just a suggestion!

Screenshot from 2023-03-08 17-16-50

johncardiologs avatar Mar 08 '23 22:03 johncardiologs

Hey @johncardiologs thanks for the change. I'm okay with that change but this action worked differently for years. It's not great to change that out of a sudden.

Could you instead put this behavior behind a new optional configuration? so that the default behavior remains unchanged.

z0al avatar Mar 10 '23 11:03 z0al

Would also love to see this get merged in, happy to help if additional work or testing needed.

houserx-jmcc avatar Aug 10 '23 19:08 houserx-jmcc

@z0al lets get this merged