Status remains pending even after closing the dependent issue

[Assem-Hafez]

The issue is in the same repository. Here are the used config:

name: Dependent Issues

on:
  issues:
    types:
      - opened
      - edited
      - closed
      - reopened
  pull_request_target:
    types:
      - opened
      - edited
      - closed
      - reopened
      # Makes sure we always add status check for PRs. Useful only if
      # this action is required to pass before merging. Otherwise, it
      # can be removed.
      - synchronize

jobs:
  check:
    runs-on: ubuntu-latest
    steps:
      - uses: z0al/dependent-issues@v1
        env:
          # (Required) The token to use to make API calls to GitHub.
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          # (Optional) The token to use to make API calls to GitHub for remote repos.
          GITHUB_READ_TOKEN: ${{ secrets.ASSEM_REPO_ACCESS_FOR_ACTIONS }}

        with:
          # (Optional) The label to use to mark dependent issues
          label: dependent

          # (Optional) Enable checking for dependencies in issues.
          # Enable by setting the value to "on". Default "off"
          check_issues: off

          # (Optional) A comma-separated list of keywords. Default
          # "depends on, blocked by"
          keywords: depends on, blocked by

[efb4f5ff-1298-471a-8973-3d47447115dc]

maybe im being ignorant about this but ur are using v1 but this repo is already on v1.5.1. maybe that will resolve ur issue

[z0al]

are using v1 but this repo is already on v1.5.1

I understand why you would think that but in this case v1 is just an alias to the latest 1.x.x so you don't have to update your config whenever there is a compatible change. It's a common practice with GitHub actions

[z0al]

Hi @Assem-Hafez , is the repo in question public by any chance so I could take a look?

[efb4f5ff-1298-471a-8973-3d47447115dc]

hi @z0al i have the same problem

see https://github.com/efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube/pull/18

name: Dependent PRs

on:
  pull_request_target:
    types:
      - opened
      - edited
      - closed
      - reopened
      # Makes sure we always add status check for PRs. Useful only if
      # this action is required to pass before merging. Otherwise, it
      # can be removed.
      - synchronize

  # Schedule a check every two hours. Useful if you reference cross-repository
  # issues or pull requests. Otherwise, it can be removed.
  schedule:
    - cron: '0 */2 * * *'

jobs:
  check:
    runs-on: ubuntu-latest
    steps:
      - uses: z0al/[email protected]
        env:
          # (Required) The token to use to make API calls to GitHub.
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          # (Optional) The token to use to make API calls to GitHub for remote repos.
          GITHUB_READ_TOKEN: ${{ secrets.GITHUB_READ_TOKEN }}

        with:
          # (Optional) The label to use to mark dependent issues
          label: "PR: dependent"

          # (Optional) Enable checking for dependencies in issues.
          # Enable by setting the value to "on". Default "off"
          check_issues: off

          # (Optional) Ignore dependabot PRs.
          # Enable by setting the value to "on". Default "off"
          ignore_dependabot: off

          # (Optional) A comma-separated list of keywords. Default
          # "depends on, blocked by"
          keywords: depends on, blocked by

          # (Optional) A custom comment body. It supports `{{ dependencies }}` token.
          comment: >
            Alright! Looks like we need to wait for some _dependencies:_

            {{ dependencies }}
            

            Don't worry, I will continue watching the list above and keep this comment updated. To add or remove a dependency please update the description of this PR.

[z0al]

@efb4f5ff-1298-471a-8973-3d47447115dc I checked the log and it looks like this:

Run z0al/[email protected]
Context
  Payload issue: None or closed
  No. of open issues: 1
Checking #18
  Depends on: #17, #16
  Blocked by: 
  Updating labels
  Updating Action comments
  Updating PR status. Skipped

The action skipped updating the PR status thinking it's a normal issue, not a PR. There is something wrong with that check. I will have to check later. Thank you for the helpful context.

~~Side note: You can remove the ignore_dependabot option as it's no longer a thing (I forgot to remove it from the readme)~~ my bad. See my comment on the referenced PR