laravel-admin icon indicating copy to clipboard operation
laravel-admin copied to clipboard

Spec selector overwrites header

Open oneWaveAdrian opened this issue 2 years ago • 4 comments

  • Laravel Version: 9.2
  • PHP Version: 8.0.2
  • Laravel-admin: 1.8

Description:

When Spec Selector ist added to a grid, the grid's header is overwritten. The footer continues to work as expected.

Steps To Reproduce:

  1. add header
  2. add spec selector

oneWaveAdrian avatar Jun 16 '22 17:06 oneWaveAdrian

bump

oneWaveAdrian avatar Jul 05 '22 22:07 oneWaveAdrian

This is how spec selector is implemented.

public function selector(\Closure $closure)
{
    $this->selector = new Selector();

    call_user_func($closure, $this->selector);

    $this->header(function () {
        return $this->renderSelector();
    });

    return $this;
}

lio990527 avatar Jul 06 '22 06:07 lio990527

I saw that, and imho the problem is, that header is overwritten, whilst logically it should be amended.

oneWaveAdrian avatar Jul 06 '22 11:07 oneWaveAdrian

Bump

oneWaveAdrian avatar Jul 21 '22 12:07 oneWaveAdrian

Bump

oneWaveAdrian avatar Oct 27 '22 11:10 oneWaveAdrian