InnerTune icon indicating copy to clipboard operation
InnerTune copied to clipboard

Lyrics

Open noClaps opened this issue 3 years ago • 3 comments

Checklist

  • [X] I've checked that there is no other issue about this feature request.
  • [X] This issue contains only one feature request.
  • [X] The title of this issue accurately describes the feature request.

Feature description

The app should have lyrics for songs, when available. It can be present on the music player screen, and accessible either by tapping the cover (Retro Music implementation), or in a section below the player (YT Music/Spotify implementation).

Why do you want this feature?

Being able to see the lyrics is a feature present in most music players.

Additional information

There's another music player, ViMusic, that displays lyrics to songs. Maybe you can use a similar approach to them to get lyrics? Another option is to use Genius, similar to how spotdl do it.

noClaps avatar Jun 05 '22 18:06 noClaps

Maybe you can use a similar approach to them to get lyrics?

Yes, it's feasible.

z-huang avatar Jun 09 '22 15:06 z-huang

I also look forward for this feature! I'm loving the app so far

Reffler avatar Sep 23 '22 15:09 Reffler

This will be added along with the player redesign.

z-huang avatar Sep 24 '22 05:09 z-huang

Overall feature completed. Additional features to be implemented:

  • [x] Add an option to align lyrics left/center/right
  • [x] Add an option to disable KuGou lyrics provider in privacy settings
  • [x] Switch lyrics provider
  • [x] Edit lyrics
  • [x] Keep screen on when lyrics enabled

If interested, please try the debug version and report bugs.

z-huang avatar Oct 22 '22 15:10 z-huang

Thanks, everything works fine, but how can I copy the lyrics files? (.lrc)

xmha97 avatar Oct 22 '22 21:10 xmha97

The lyrics are stored as string in the database, so you won't find them in the app's file directory. Maybe I can export them with SAF.

z-huang avatar Oct 23 '22 01:10 z-huang

Note: scrolling of the LyricsView isn't smooth enough and needs tweaking.

z-huang avatar Oct 23 '22 15:10 z-huang

Now it should be smooth. Feedback welcomed.

z-huang avatar Oct 26 '22 15:10 z-huang