InnerTune icon indicating copy to clipboard operation
InnerTune copied to clipboard

Add support for sdk21, updated some versions

Open Osanosa opened this issue 1 year ago • 3 comments

This is my first pull request ever, so tell me if I fucked smth up

Osanosa avatar Mar 23 '24 01:03 Osanosa

Looks like minification in release build breaks audio download, no idea how to fix it, prob will need some rule for ProGuard, mut without minification works fine

Osanosa avatar Mar 23 '24 02:03 Osanosa

Why are we trying to support android 5.0 here (almost 10 years old) - sorry but I don't think implementing this makes sense. This is not a legacy app. Or am I missing something :fearful:

ghost avatar Apr 30 '24 16:04 ghost

Why not if compose is capable of? The only thing that's holding it is some sort of converting Chinese character set and that's it. If this can be simply disabled for outdated versions than it can run.

On Tue, Apr 30, 2024, 19:40 BabyBenefactor @.***> wrote:

Why are we trying to support android 5.0 here (almost 10 years old) - sorry but I don't think implementing this makes sense. This is not a legacy app. Or am I missing something 😨

— Reply to this email directly, view it on GitHub https://github.com/z-huang/InnerTune/pull/1253#issuecomment-2085930061, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATD6MCCGANPV47OIOBZPXS3Y77CPZAVCNFSM6AAAAABFEGWXZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBVHEZTAMBWGE . You are receiving this because you authored the thread.Message ID: @.***>

Osanosa avatar May 01 '24 07:05 Osanosa

According to statistics, very few people use Android 5.0. Not planned to support api 21.

z-huang avatar Aug 07 '24 04:08 z-huang