CPod icon indicating copy to clipboard operation
CPod copied to clipboard

Queue function not working

Open Mpkch opened this issue 4 years ago • 7 comments

CPod version: 1.28.0 Platform: Windows 10 Installation type (.deb, Snap, etc.): CPod-Setup-1.28.0.exe

Description: Queue function doesn't work - popup appears to say that episode is queued, but Queue remains empty

cbus-ui.js:920 Uncaught TypeError: Cannot read property 'fromUI' of undefined
    at Object.callback (cbus-ui.js:920)
    at Object.cbus.broadcast.send (cbus-broadcast.js:8)
    at Object.enqueue (cbus-audio.js:279)
    at HTMLButtonElement.elem.getElementsByClassName.onclick (cbus-ui.js:620)

(anonymous) @ cbus-ui.js:920
cbus.broadcast.send @ cbus-broadcast.js:8
enqueue @ cbus-audio.js:279
elem.getElementsByClassName.onclick @ cbus-ui.js:620

Version of CPod which introduced the issue (if applicable):

Steps to reproduce: Select any podcast episode and click on the Add To Queue icon. The "added 'episode name' to Queue popup appears as intended, but error above is thrown in the console. Queue is empty

Other information (e.g. Developer Tools console log, screenshots) if possible:

Mpkch avatar Aug 20 '21 08:08 Mpkch

I have the same issue on Windows 10 x64

kadykov avatar Sep 21 '21 19:09 kadykov

The problem is the queueUpdate message is sent from both cbus-ui.js and cbus-audio.js, and is listened to by cbus-ui.js, cbus-audio.js and cbus-data.js, but only within cbus-ui.js is there a {fromUI: true} data field passed, the remainder of the .send(queueUpdate) statements do not pass a data field, which causes the error message.

leighsmith avatar Sep 21 '21 20:09 leighsmith

The easy fix is to simply add {fromUI: false} to all of the statements with .send("queueUpdate"), but it's not clear if indeed that fromUI should be declared as false, or true in which cases?

leighsmith avatar Sep 21 '21 20:09 leighsmith

OK there is a fix on my branch but it's really just a one line change.

leighsmith avatar Sep 21 '21 20:09 leighsmith

same issue here, im using linux appimage.

Desconvidado avatar Oct 07 '21 21:10 Desconvidado

Hi, are we expecting a new release any time soon. I also got the queue issue from Linux AppImage release.

Xunius avatar Feb 17 '22 13:02 Xunius

Hi, are we expecting a new release any time soon. I also got the queue issue from Linux AppImage release.

Bump for anniversary

pessimal avatar Feb 17 '23 09:02 pessimal