pyod
pyod copied to clipboard
Fix layer count in autoencoder detector
Resolves #138 Resolves #146 Resolves #254
This PR fixes a problem with the number of layers in the AutoEncoder
detector. In the current master
, the input layer is duplicated due to a bug in the loop where the hidden layers are added. The issue is fixed here. I have also added a test to ensure that the number of layers matches expectations.
All Submissions Basics:
- [x] Have you followed the guidelines in our Contributing document?
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
- [x] Have you checked all Issues to tie the PR to a specific one?
All Submissions Cores:
- [x] Have you added an explanation of what your changes do and why you'd like us to include them?
- [x] Have you written new tests for your core changes, as applicable?
- [x] Have you successfully ran tests with your changes locally?
- [ ] Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
- [ ] Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.
Hey @yzhao062, sorry for jumping in unannounced with this. I have been using the AutoEncoder
detector in pyod
recently (awesome library you've created!) and noticed a problem with the number of layers in the model. Browsing through the issues, it seems several others have noticed this as well. The fix was easy, so I figured I would open a PR and add a test.
sorry for being late on this~ I was in moving from my PhD to new faculty job and was totally losing track on this. Could you resubmit this PR to the development branch? I am not back to this!
No problem. I've changed the base branch to the development branch. I don't see any automatic CI test runs, so I'll close and reopen to see if that triggers them. Edit: No 😢