combo icon indicating copy to clipboard operation
combo copied to clipboard

Plan to integrate Numba

Open nottatdat opened this issue 6 years ago • 2 comments

Hi there!

I'm currently using combo for my projects, and it appears to me that the library is quite slow. Is there any plan to add numba, as mentioned in the README, to speed it up?

I have had some experiences with numba and will be more than happy to help!

nottatdat avatar Nov 18 '19 12:11 nottatdat

Hi there,

Thanks for the interest. My gut feeling is numba would not help that much as the major part is combining models and not too much numpy calculation is involved. but u r welcome to see if there is a fit. If so, feel free to submit a PR :)

Best,

Yue

yzhao062 avatar Nov 18 '19 18:11 yzhao062

Thanks for your insights! Will try to add numba to see if there's any differences.

nottatdat avatar Nov 19 '19 16:11 nottatdat