vscode-markdown icon indicating copy to clipboard operation
vscode-markdown copied to clipboard

Math syntax (delimiter style) is not compatible with GitLab

Open toger5 opened this issue 4 years ago • 16 comments

Git lab requires $`19+1=20`$ but markdown all in one does not is expects $19+1=20$ .

toger5 avatar Dec 11 '19 00:12 toger5

There is no unified syntax for Math (in Markdown) so we probably can't have a good solution on this.

yzhang-gh avatar Dec 11 '19 03:12 yzhang-gh

Is it possible to provide it as an option in the vs code markdown renderer? math-syntax-flavor = {gitlab | basic}

toger5 avatar Dec 11 '19 23:12 toger5

It is a bit hard. We are currently relying on markdown-it-katex for math rendering.

yzhang-gh avatar Dec 12 '19 00:12 yzhang-gh

maybe we could switch to markdown-it-texmath

the texmath project provides a possibility to select the delimiter one wants to use

Screenshot_20200309_163919

on a fast check the texmath repo has more recent updates:

NeroBurner avatar Mar 09 '20 15:03 NeroBurner

I would suggest Markdown+Math extension, from the author of markdown-it-texmath 😂.

yzhang-gh avatar Mar 09 '20 17:03 yzhang-gh

maybe invite @goessner to work together on one extension using markdown-it-texmath. Then you'd have one more developer, one less competing extension, more user option (specify inline math delimiter) and a very good connection to the backend developer

just a suggestion :man_shrugging:

NeroBurner avatar Mar 10 '20 07:03 NeroBurner

I'm open to the collaboration of course. It just looks like Markdown+Math has already covered its target users (who need better math support), while this extension targets common Markdown users.

yzhang-gh avatar Mar 10 '20 08:03 yzhang-gh

what about users who want math support and the features if vscode-markdown. are they compatible?

toger5 avatar Mar 21 '20 23:03 toger5

I have added an option math.enabled. They should be compatible now (in terms of the VSCode's builtin preview).

(the dev build)

yzhang-gh avatar Mar 22 '20 02:03 yzhang-gh

dev build is not accessible. Project not found or access denied. I try to access other projects such as https://ci.appveyor.com/project/benvanik/xenia and it's accessible.

yxs avatar Mar 30 '20 05:03 yxs

It has been moved to https://github.com/yzhang-gh/vscode-markdown/actions/runs/64661491.

yzhang-gh avatar Mar 31 '20 07:03 yzhang-gh

I implemented markdown-it-texmath intentionally as a standalone plugin for markdown-it-texmath usable with node.js and in browsers.

So if it serves the needs of you and your users ... go ahead and take it.

Thanks for your interest.

goessner avatar Apr 05 '20 12:04 goessner

Thanks you @goessner. Your extension provides a very nice support of math in Markdown. Let's first see whether our two extensions can work seamlessly now. Further, we can also work together if integration is needed for better user experience.

yzhang-gh avatar Apr 06 '20 09:04 yzhang-gh

Hmm ... I am totally happy with my mdmath vscode extension, so it doesn't need to work together with your extension from my point of view.

I only make an offer, that you can use my markdown-it plugin markdown-it-texmath in your vscode extension ... that's all. Of course you need to test for possible conflicts.

thanks

goessner avatar Apr 06 '20 12:04 goessner

Hmm ... I am totally happy with my mdmath vscode extension, so it doesn't need to work together with your extension from my point of view.

I totally agree. I just wanted to say I'm willing to do something if collaboration would be needed 😅. I've made some changes to my plugin so that some users can use this one in parallel to mdmath. That's the solution I suggested earlier under this issue. Sorry for the confusion.

yzhang-gh avatar Apr 06 '20 12:04 yzhang-gh

Just ran across this issue. Just fyi, we're working on adding $ and $$ support in GitLab, https://gitlab.com/gitlab-org/gitlab/-/issues/21757

digitalmoksha avatar Sep 06 '22 22:09 digitalmoksha