vscode-markdown-pdf icon indicating copy to clipboard operation
vscode-markdown-pdf copied to clipboard

Fix rendering Mermaid diagrams to PDFs and images

Open haensen opened this issue 1 year ago • 6 comments

Fixes issues #312, #318, #337 and #342. Also, enables using Mermaid's newest features like xychart-beta with this tool.

The root cause of the problem was that sometime after and around version 10.5 Mermaid started using features that were unsupported by the Chromium version that this tool used. At least structuredClone-function was one such feature. So this fix pumps the Puppeteer from version 2.21 to 22.7.1, which pumps Chromium from version 80 to 124.

Also, the line that removes Chromium from the package is removed, because after Puppeteer v19 Chromium is stored to ~/.cache, which doesn't affect the package size.

haensen avatar May 02 '24 21:05 haensen

Please merge, would be nice mermaid would work again.

bqstony avatar Nov 11 '24 08:11 bqstony

Seems that the repo has been inactive for some time. I recently installed and wanted to use mermaid features, but noticed they were not displayed. Any other alternative? Merging this will be awesome.

ricardo-dlc avatar Jan 08 '25 18:01 ricardo-dlc

Still wanting a merge on this if possible. Any updates on the state of this PR?

jorgeLandTO avatar Mar 06 '25 00:03 jorgeLandTO

@yzane When will it get merged? Or is this whole project dead? And this is the continuation (https://github.com/showzs/vscode-markdown-pdf)?

formeo14 avatar Mar 24 '25 23:03 formeo14

Here's the plugin file for this PR if somebody wants to install. VSIX Release

haensen avatar Mar 31 '25 15:03 haensen

@yzane When will it get merged? Or is this whole project dead? And this is the continuation (https://github.com/showzs/vscode-markdown-pdf)?

I'm going to guess "no" since (a) it's 17 commits behind the original project, and (b) hasn't been updated since 2023. Many thanks to @haensen for providing an updated VSIX file that resolves the issue!

athompson-merlin avatar May 13 '25 21:05 athompson-merlin