Git-Web-Access icon indicating copy to clipboard operation
Git-Web-Access copied to clipboard

Incorrect URL for repository if base path ends with '\'

Open ivan-danilov opened this issue 13 years ago • 0 comments

At this line you are assuming that basePath does not have backslash ('') in the end and FullName has. While the latter is correct because there's some non-empty relative path after base path, former is incorrect because user can enter any string she wants.

As the result if basePath has backslash at its end, user would see first char cut. For example if repository is abc.git, user will see URL 'http://localhost/bc.git' which is incorrect.

ivan-danilov avatar Jan 10 '12 18:01 ivan-danilov