Ivan Yonchovski

@jiacai2050 can you test with default theme(e. g. after M-x disable-theme)? In case you still see the error, can you test after setting `lsp-diagnostic-package` to `:none`? I suspect that we...

@Xeite do you have a config + steps to reproduce?

The CI is red: https://github.com/emacs-lsp/lsp-mode/actions/runs/8353897412/job/22866353094?pr=4384#step:12:631 . You should use the corresponding declare-functions to make it pass.

> I realize the way lsp works might not mesh very well with how emacs completion works. I would assume that is why it is not being a "good citizen"...

> I don't know if lsp currently has hooks for lsp-server specific project initialisation routines, but I think it would help. Happy to take a crack at it, if it's...

> aha, realising initialisation-options is unnecessary here, we can do everything in the `lsp-clients--clangd-command` Yes. The tricky part is that workspace root is not available in the initial import of...

you should use `lsp-workspace-root` but it will return nil before you have imported the project. But again, this will change.

> how far in the future is this change? It sounds like I should wait until it lands and proceed after that? I can't tell - I will be inactive...

Thanks for the contribution but I have some concerns. `lsp-register-custom-settings` is supposed to be replaced by lsp-defcustom which does not have the option to use the `new` version because it...

> so changes like [782e1dc](https://github.com/emacs-lsp/lsp-mode/commit/782e1dc15a590ae9aa2c9b7e39c4cc8a65952e13) will be happening and regressing random users. The point is that when we migrate that file to lsp-defcustom you will still get the same issue...