Yong

Results 102 comments of Yong

There's a related issue #8736, that we think when bumping the fees of a given input, if it's already in a set, we would instead bump the whole set to...

> But in the extreme case of a next-block deadline, LinearFeeFunction will return the min feerate instead of the max, which is quite bad. What do you mean by saying...

Thank you for catching this! I forgot to mention I wanna more opinions here re how we decide the deadline in this case. I don't think we can use the...

> So the basic idea is to synchronize the entire contractcourt and sweeper on each block? Yes. > Do arrows in the above diagrams represent passing around the latest block...

> But the sweeper gets the block info directly from BlockBeat, right? Yeah exactly. > So basically BlockBeat (1) sends block info to contractcourt, then (2) sends block info to...

Good question @morehouse. I need to think about it more, whether `UtxoSweeper -> TxPublisher`, or the other around, or in parallel. The issue with `TxPublisher -> UtxoSweeper` means every tx...

I think we should return the error here to be handled by the callers instead of returning the fee floor, https://github.com/lightningnetwork/lnd/blob/2089a88f4b5e97a19a9d0a3940222cc90946701a/lnwallet/chainfee/estimator.go#L778-L790 Looking at other implementations of `EstimateFeePerKW`, think we should...

This should happen after #8424, and should be straightforward as we can skip the aggregation by adding a `NoAggregation` implementation. On the other hand, we'll need to update `btcwallet` and...

Just realize `GetPeerInfo` is already implemented here: https://github.com/btcsuite/btcd/blob/master/rpcclient/net.go#L354 Since this is a `feefilter` msg sent by our peers and we just cache it, I don't think calling `GetPeerInfo` periodically is...