Yaroslav Yaremenko

Results 27 comments of Yaroslav Yaremenko

also, @xabbuh, since I have a chance to speak to you directly, I have one more question: https://symfony.com/doc/master/bundles/FOSRestBundle/7-manual-route-definition.html says, in the very beginning > If the automatic route generation does...

taking ClassDefinition tests

hey @ddmler I've found some misprint in your test-related code - 'defiNTion' instead of 'defiNITion', so I'm fixing that as well

@ddmler please consider updating phpunit to 5.*, as current "^4.8.26" version is way too out of date

@ddmler @ovr guys looks I've found a serious bug in the code while writing tests: PHPSA\Definition\ClassDefinition constructor allows $statement to be of null type; in the other hand, complie() line...

guys, please reply ASAP, I am blocked (can not proceed with writing tests)

My point is that, in case of custom handling, there should be either two events, or none (because if it's custom handler's business to dispatch a post_serialize event, then it...

well, I am not the bundle developer, so I can't really know what is the proper way to fix the thing, so I prefer to believe you here and I...

yep, I can do the fix; so, I should make sure the post_serialize event is dispatched no matter if custom handler is given or not. did I understand you correctly?