Walt Karas

In what cases are updates by TSSslSecretSet() actually used?

15

I'm running a test with this `ssl_multicert.config` file: ``` dest_ip=* ssl_cert_name=2050.crt ssl_key_name=private.key ``` The cert in 2050.crt expires in the year 2050. The steps of the test are: 1. Execute...

HostDBHash::set_host(): null termination (and lifetime) of string parameter ambiguous.

2

The prototype, https://github.com/apache/trafficserver/blob/bfd5265fd21b45c5fff0affdf8a3b88330d8181a/iocore/hostdb/HostDB.cc#L172 , implies the string is not null terminated. But it seems to assume the string is null terminated. in line 180. We also seem to be sending...

"Release Process" section of sphinx documentation needs updates.

1

https://docs.trafficserver.apache.org/en/10.0.x/developer-guide/release-process/index.en.html# There are references to autotools and SVN.

Problems with TSPortDescriptor (TS API).

3

1. TSPortDescriptorParse() returns a pointer to a dynamically allocated object. There is no way to delete this object so it would be leaked ( https://github.com/apache/trafficserver/blob/85d50c2d7e916e7e30c698fdb1c32b1db7779455/src/traffic_server/InkAPI.cc#L8917 ). 2. This capability is...

Regression tests should be refactored as Au and Catch tests

2

That is, the regression tests run with the -R option on the traffic_server command. There seems to be consensus that these tests are hard to maintain. Related issues: https://github.com/apache/trafficserver/issues/5048 https://github.com/apache/trafficserver/issues/2637...

Plugins and non-zero number_of_redirections

3

If a plugin (header_rewrite for example) sets the reply status to 301, and proxy.config.http.number_of_redirections is non-zero, will it follow the redirect (and should it)?

Need to switch from ink_atomic.h to Standard lib <atomic>

2

This is not simply a cosmetic issue. ink_atomic.h effectively assumes there is no need for memory fence instructions on any architecture that TS runs on: https://github.com/apache/trafficserver/blob/77714f253f3a3ab4ce39877da52e14b6270f6868/include/tscore/ink_atomic.h#L171 For x86 architectures for...