Walt Karas comments

Results 115 comments of


                                            Walt Karas

Don't assume LogAccess::m_client_req_unmapped_url_canon_str is null terminated.

This change has been running in Yahoo prod for about two weeks. It stopped memory corruption that was previously causing frequent crashes.

Don't assume LogAccess::m_client_req_unmapped_url_canon_str is null terminated.

> Other functions around this function use `ink_strlcpy`. Doing a different thing just for this case doesn't look like a right way. Can the other functions have similar issue and...

Don't assume LogAccess::m_client_req_unmapped_url_canon_str is null terminated.

Why would we want to leave the crash in 9.x?

Don't assume LogAccess::m_client_req_unmapped_url_canon_str is null terminated.

Is 9.1.x no longer supported (with maintenance releases)?

Debug Tags of Plugins Cannot Be Turned On at Startup

Is the problem you are seeing different from this one? https://the-asf.slack.com/archives/CHQ1FJ9EG/p1706825958698989

IP: Change DNS nameserver code to use libswoc.

[approve ci]

☂ cmake: audit tasks

My development environment is in a x86_64, RHEL8(-ish, Yahoo kernel mods) container in the Yahoo internal cloud. The autotools ./configure detects it as supporting 128 bit CAS. cmake detects in...

☂ cmake: audit tasks

-Djemalloc_ROOT=xxx doesn't seem to be working. update: It works when combined with -DENABLE_JEMALLOC=ON .

☂ cmake: audit tasks

Some Catch unit tests are missing in the CMake build: wkaras ~/REPOS/TS O$ cat ~/find_catch CML=$( find . -name CMakeLists.txt ) LAST='___NONE___' grep -l -F CATCH_CONFIG_MAIN $( find . -name...

☂ cmake: audit tasks

It looks like there may be over 200 c/cpp/cc file that appear in a Makefile.am or Makefile.inc file, but not in a CMakeLists.txt file. I will work on addressing this.