Walt Karas comments

Results 115 comments of


                                            Walt Karas

Add Au test for TSVConnFdCreate().

The review could be split between two reviewers. One could review TSVConnFd.cc lines 1 - 429. The other could review the rest of that file and the other files.

Fast log buffer

What performance difference does your benchmark show? How about a cut-n-paste of the output?

Fast log buffer

Has this been tested in production at all?

Au test spawning a blocking thread in a transaction hook continuation.

> API review on dev@ ? There is not change to the TS API.

Au test spawning a blocking thread in a transaction hook continuation.

> > > API review on dev@ ? > > > There is not change to the TS API. > > plugins/xdebug/Cleanup.h → include/tscpp/api/Cleanup.h > > You are introducing a...

Au test spawning a blocking thread in a transaction hook continuation.

I tried to, maybe my e-mail is blocked. On Mon, Aug 29, 2022 at 7:00 PM Masakazu Kitajo ***@***.***> wrote: > @ywkaras > > I meant you should send API...

Au test spawning a blocking thread in a transaction hook continuation.

``` MIME-Version: 1.0 Date: Mon, 22 Aug 2022 10:25:18 -0500 Reply-To: [email protected] Message-ID: Subject: Proposed change to CPP API From: Walt Karas To: dev Content-Type: multipart/alternative; boundary="0000000000002acc7f05e6d60ebf" --0000000000002acc7f05e6d60ebf Content-Type: text/plain;...

Au test spawning a blocking thread in a transaction hook continuation.

> Thanks for proposing the API change on the list. The change should be made separately even if it's accepted. How would I do that? I an using definitions in...