ywave620

Results 29 comments of ywave620

@bnoordhuis @bnoordhuis @vtjnash Shall we proceed to get this PR landed?

Should this change go to v1.x ?

@bnoordhuis It would be appreciated that if you could move this PR forward.

@bnoordhuis @vtjnash Would you mind helping land this PR?

> I'm using `lazyConnect: true` and I noticed, if the connection is already established and I then close the Redis server, ioredis keeps spamming `unhandled error event` even though I...

`importModuleDynamically()` callback is invoked everytime the `import` statement in the code paased to the `vm` is evaluated. The essential problem here is that it takes a `vm.Script` instance(created by`vm.runInThisContext()`) or...

In case anyone who is confused, the dilemma we have now: 1. The lifetime of `CompiledFnEntry`(stored in `Environment::id_to_function_map`) is bounded to the `Function` created as a result of `vm.compileFunction()`, since...

I would like to hear your ideas :) @legendecas

@legendecas Great! Some thoughts on your work: - In the first sight, host defined options should be something belonged to a script, rather than a context. - In addition, the...

In the latest node, the actual object passed as the second argument of `importModuleDynamically()` callback is not the correct value for`referencingScriptOrModule` mentioned in the spec, do you agree? @legendecas The...