Hashtags ('#') in password string cause pushing to remote to fail

[slyboots]

when pushing to a remote using stash, if the password string contains a hashtag ('#') it will cause a urllib error 401 if on the right side of the colon (' : ') and a bad request error if on the left side. Im running in iPhone 6 plus w/ iOS 10 and pythonista 2

[slyboots]

Also this isnt a serious issue, I guess most people don't have hashtags in their password strings and now neither do I.

[oefe]

git push embeds the password in the url, which is deprecated according to RFC 3986.

[ywangd]

Somehow I just noticed this issue. My guess is that any texts after # is interpreted as comments as like in Bash. So to avoid # being treated as start of comments, you can single quote your entire URL, e.g. git push 'url_containing_#_char'

[jsbain]

@oefe This is mostly for interaction with dulwich, keeping with the other transport types. The url is not actually sent over the wire this way -- this gets stripped out into an HTTPBasicAuthentication flow.