openspades icon indicating copy to clipboard operation
openspades copied to clipboard
verified publisher icon yvt

expand disconnect reasons

Open NotAFile opened this issue 6 years ago • 2 comments

add the new disconnect reasons

NotAFile avatar Mar 25 '19 13:03 NotAFile

Should we use https://github.com/piqueserver/aosprotocol/issues/15 instead of adding more fixed strings?

BR- avatar Mar 27 '19 20:03 BR-

There's a few things with that:

  • Those messages aren't localized to the local language of the user
  • There are already installs out there using these new error codes. If we don't add them, they will show up as "Unknown Reasons" instead.
  • It really doesn't hurt to have more reasons here. It's a simple change. Adding that proposal is good but takes more code, so I haven't done it for now.

NotAFile avatar Mar 27 '19 21:03 NotAFile