yuzu icon indicating copy to clipboard operation
yuzu copied to clipboard

arm_dynarmic: Fix nullptr fastmem arenas

Open merryhime opened this issue 1 year ago • 1 comments

Many thanks to @vladkosi for investigating the underlying issue regarding non-functioning on earlier versions of Windows. See: merryhime/dynarmic#701.

On earlier versions of Windows, because they do not support modern memory allocation APIs, the fastmem pointer would be nullptr. Yuzu attempts to enable fastmem of exclusive accesses without a valid fastmem arena, which is not a valid state to be in. Dynarmic thus asserts internally when this happens.

Verification would be helpful as I am unable to test this.

merryhime avatar Aug 09 '22 19:08 merryhime

I can confirm that this has fixed the crashing. Tested on Windows 10 versions 1511 and 1803.

vladkosi avatar Aug 09 '22 21:08 vladkosi