emacs-slack icon indicating copy to clipboard operation
emacs-slack copied to clipboard

Add cookie to websocket requests

Open jumper047 opened this issue 2 years ago • 4 comments

According to @Nazar65's research, Slack now requires cookies to be added to websocket requests. Unlike the quickfix from #584, this MR sets the `Cookie' header directly to work correctly with multiple accounts. Should fix issues #584, #585

jumper047 avatar Oct 01 '23 10:10 jumper047

Tested and so far it seems to work fine. Thank you :-)

Konubinix avatar Oct 09 '23 08:10 Konubinix

Actually, it looks like it make the problem appear less often. After ~8 hours of connection, I get the 429 errors again... Don't you @jumper047  ?

Konubinix avatar Nov 02 '23 15:11 Konubinix

Actually, quitting emacs and going back seems to make the 429 error go away for a few hours again.

Konubinix avatar Nov 02 '23 16:11 Konubinix

@Konubinix yep, same for me. No matter what approach I used - this PR, or url-cookie-store from issue, result is the same: it works some time, then it stops working(429 errors or recurring reconnects), and works again after emacs restart.

jumper047 avatar Nov 03 '23 09:11 jumper047

thanks @jumper047 for your contribution, it got in master via isamert repo. Also the lc cookie is necessary now!

ag91 avatar Nov 18 '24 23:11 ag91