emacs-slack icon indicating copy to clipboard operation
emacs-slack copied to clipboard

Add support for downloading files with `xoxc` tokens

Open isamert opened this issue 3 years ago • 6 comments

slack-url-copy-file was not compatible with xoxc tokens which requires cookie to be present with the request. So this MR simply fixes that.

I only tested these changes with an xoxc token, so I'm not sure that it works with other tokens that do not require the cookie but there are no reasons for this to not work.

isamert avatar Dec 30 '21 17:12 isamert

Note, this fixes #558

jsilve24 avatar Dec 30 '21 19:12 jsilve24

Please merge this PR bcs it's really useful fix :)

Nazar65 avatar Jan 19 '22 19:01 Nazar65

Please merge

jsilve24 avatar Feb 11 '22 16:02 jsilve24

I can confirm this fixes image downloading for me with an xoxc token.

adamcstephens avatar Jun 17 '22 14:06 adamcstephens

another happy user, this fixes it for me :grinning:

unhammer avatar Sep 30 '22 09:09 unhammer

Works for me to. Thank you @isamert

Konubinix avatar Aug 30 '23 12:08 Konubinix