Yu Watanabe

Results 292 comments of Yu Watanabe

Maybe, this needs to be rebased?

> Are there any guidelines how to format comments in code? Not sure that my comments follow the required style. All comments seem to be formatted in a good shape....

BTW, I'd like this to be split into at least 3 commits: 1. drop the unused flag, 2. introduce new method and signal, 3. use the new method and signal...

@poettering Thank you for the review. Most of comments are addressed. PTAL.

@poettering Thank you for the review. The commit message and the comment in the code is updated. Also, the cleanup logic is updated. PTAL.

@poettering and @keszybz Thank you for many comments. - tempfn_xxxxxx() or friends now truncate the original filename. - adds several tests for tempfn_xxxxxx() and friends. - adds several tests for...

@msekletar If you'd like, could you take a look? I hope this is better than the previous logic of 'try-and-wait' loop, and possibly improves performance, though I have not run...

The lock file is not exposed to unprivileged users, hence we can safely use the _UNPOSIX_ lock used by `make_lock_file_for()`. But, I do not like the implementation that it unlink()...

> Glad to see that the userspace lock free algo thingy is going to be abandoned eventually. I'm not sure to understand why the flock approach is now acceptable by...