Yu Watanabe
Yu Watanabe
Is this for v259?
> Another question on the workflow: I guess this is the one who comments then resolves conversation on github if comment is addressed? Thanks Yeah, please close resolved comments.
> @yuwata I've pushed the latest changes: do you want me to squash those? Yeah, please squash when you push next time. It is OK now, as not finished yet....
CIs are unhappy...
> > CIs are unhappy... > > Yeah, it is unhappy because of > > ``` > networkd.conf.xml ./refsect1[title="[ModemManager] Section Options"]/variablelist/varlistentry[term="SimpleConnectProperties="] is undocumented > Hint: if you reorganized this part...
> > Please update tools/command_ignorelist. > > ``` > diff --git a/tools/command_ignorelist b/tools/command_ignorelist > index 2cdaf4de7f72..765fa2e872e9 100644 > --- a/tools/command_ignorelist > +++ b/tools/command_ignorelist > @@ -51,6 +51,7 @@ logind.conf.xml ./refsect1[title="Options"]/variablelist/varlistentry[term="Kill...
@andr2000 Sorry for late review. We are busy for final release steps for v259. I will review after v259 is released.
About persistent storage, it is necessary to wait for io.systemd.Network.SetPersistentStorage method is called. See `vl_method_set_persistent_storage()`. I guess you can easily extend it to also make the DHCP clients store leases...
The mechanism is required because when /var/ is in a separated filesystem from / or /usr/. In that case, networkd may be started before /var/ is mounted, and networkd cannot/should...
@rajibade If the PR is in 'draft', the auto labeling does not set 'please-review' tag, and we easily forget your work. Please push `Ready for review` button when you want...