jupyter-desktop-server icon indicating copy to clipboard operation
jupyter-desktop-server copied to clipboard

Ship noVNC's client side with our package

Open yuvipanda opened this issue 5 years ago • 5 comments

In our postBuild, we download noVNC just to use the client side. We then use sed to make some changes.

Instead we should figure out... something else :D Options are:

  1. Vendor just the files we need from novnc
  2. Use the novnc js client to build our own minimal UI

I think 2 is the solution we should go for

yuvipanda avatar Oct 29 '19 19:10 yuvipanda

FYI I chose vnc_lite.html over vnc.html because the latter seems to be a full application rather than just a basic viewer. vnc.html uses LocalStorage to save your current settings including the backend websocket path. This is a big problem running on mybinder since the storage is associated with the domain whereas each desktop is completely independent, and you end up with noVNC attempting to connect to an old non-existent binder.

This was incredibly hard to debug, so thought I'd mention it in case you weren't aware!

manics avatar Nov 06 '19 00:11 manics

@manics: I however tried to use vnc.html with jupyterhub but I can't get it to work. Connection always fails. Do you have any idea of the necessary changes?

djangoliv avatar Jan 21 '21 10:01 djangoliv

I can't remember whether I ever got it working.

manics avatar Jan 21 '21 19:01 manics

ok thanks.

djangoliv avatar Jan 22 '21 06:01 djangoliv

ok thanks, I will keep on searching.

djangoliv avatar Jan 22 '21 06:01 djangoliv