Results 120 comments of Yuval Lifshitz

@Suyashd999 thank you for the detailed report! I think that we will have to go fo the option of running clang-tidy only on the files modified in the test. this...

> 1. To get `compile_commands.json` we need to run `./do_cmake.sh -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=ON`, > The first line of `do_cmake.sh` is `git submodule update --init --recursive --progress --recommend-shallow` So we need to wait...

> @yuvalif Great success 🎉 ![image](https://private-user-images.githubusercontent.com/109069262/407779130-eb2e3eeb-72c1-4157-b9f2-0fb9dd57a5cc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzgxNjMzMDMsIm5iZiI6MTczODE2MzAwMywicGF0aCI6Ii8xMDkwNjkyNjIvNDA3Nzc5MTMwLWViMmUzZWViLTcyYzEtNDE1Ny1iOWYyLTBmYjlkZDU3YTVjYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEyOVQxNTAzMjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hNDJmMjZmY2RjNDAxM2RhNjQ3ZjBmZjJkNjQ0M2FhY2RlYjFjYmU2ZDA4Y2E2MzdjYzhjMWRhMmM0NDlhNTQwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.QCkL7g6rFtVkJzWjYqvnZ3Q-ZW9Cdl5yPGy6wxf9dkc) > > With your insights I made the changes > > The entire Jenkins clang-tidy job only took **2 min 32 seconds** 🎉 >...

yes, it is similar concept, but in case of ceph we ae using kafka not sqs. also in cepoh we have some extensions to the bucket notification configuration that you...

> The underline component is using AWS SDK S3 Java client, so unless there is a good reason or something useful on S3 too, we won't add more configuration in...

opened the following tracker for the upgrade issue: https://tracker.ceph.com/issues/67637 (note that this is not specific to "reef")

> > @k0ste do you plan on looking into this? > > Seems I already cherry-picked 2nd commit. Need to cherry-pick something else? after an upgrade to the vesion of...

@k0ste please cherry-pick from this one as well: https://github.com/ceph/ceph/pull/53580 (the migration)

> > @k0ste please cherry-pick from this one as well: #53580 (the migration) > > The commit does not apply without conflicts. There are too many changes for me to...