emgithub
emgithub copied to clipboard
yusanshi
[Feature Request] Show Full Path in Footer
Currently emgithub only shows the file name in the folder, which does not indicate the path structure. An option to show the full path of the file in the repository would be awesome.
e.g. https://github.com/user/repository/blob/branch/src/hello.cpp#L2-L6 -> src/hello.cpp instead of hello.cpp
Sounds like a good idea. While working on v2 of emgithub, I have implemented this feature (https://github.com/yusanshi/emgithub/commit/6a5dfd9eccb2343f5dd4a944ffca9362975d0629). You can check it at https://emgithub.com/~
Some small improvements can be done though, like:
- Set the maximum path depth.
- Trim the path string if it gets too long.
I believe you mean when the path got too long as shown below...
However I think adding the option "Set the maximum path depth" may make the emgithub have too many options and too focused on the details.
I believe "Trim the path string if it gets too long" is preferred, such that when the text can't fit into one line it will get clipped and ellipsis is shown on the left. But text-overflow: ellipsis; will only trim the text on the right side. Use the direction:rtl; may do the trick but I think it may be too dirty... So currently I haven't got an effective and clean solution to this.
If you have got a better solution, PR is always welcomed. If a dirty fix is suitable for your own use cases, you can fork the project and make the changes.