idea-one-dark-theme icon indicating copy to clipboard operation
idea-one-dark-theme copied to clipboard

Color Python Docblock comments as for line-comments

Open mfitzp opened this issue 8 years ago • 5 comments

Python docblock comments are defined using triple-delimited strings but are usually styled differently (as for comments) to distinguish from actual strings.

This sets the color for PY.DOC_COMMENT to that for PY.LINE_COMMENT. As they both serve a similar purpose this seemed to make most sense.

mfitzp avatar May 22 '16 14:05 mfitzp

You might want to get the opinions of some other Python users in case I'm the odd one out, but for me this change helps reduce the visual noise in well-documented code.

mfitzp avatar May 22 '16 14:05 mfitzp

Old

pycharm_old

New

pycharm_new

Atom

atom

What do you think?

yurtaev avatar May 23 '16 16:05 yurtaev

@yurtaev is the bottom the One Dark theme on Atom (i.e. not this repo?) Should I post this suggestion 'upstream' instead?

In the example code it doesn't look like a problem - though I still think it makes it difficult to distinguish actual code strings from docs - but when you have functions documented with 20+ lines it's an overload of green.

mfitzp avatar May 24 '16 08:05 mfitzp

I try to keep it as original as possible... You might send this suggestion to https://github.com/atom/one-dark-syntax

yurtaev avatar May 24 '16 08:05 yurtaev

That makes sense, thanks for the response!

On 24 May 2016 at 10:29, Egor Yurtaev [email protected] wrote:

I try to keep it as original as possible... You might send this suggestion to https://github.com/atom/one-dark-syntax

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/yurtaev/idea-one-dark-theme/pull/9#issuecomment-221200991

mfitzp avatar May 24 '16 08:05 mfitzp