opentracing-tutorial

opentracing-tutorial copied to clipboard

Node.js Lesson 2 code does not produce multiple spans

1

After working through the lesson and then adapting the solution's code over my own, it seems that multiple spans are not produced from the code in lesson 2. I don't...

veryscarycary

Add a line to import `ImmutableMap` for `lesson01` readme

2

Would be great if you could add a line to import `ImmutableMap` ``` import com.google.common.collect.ImmutableMap; ``` to help newbies!

ackerleytng

Here's a missing import that would help newbies! (Should be added at the `#add-some-imports` section for `lesson03` for the `Formatter` and `Publisher` classes) ``` import javax.ws.rs.core.Context; ``` And some imports...

ackerleytng

added some exercise files and fixed misprints

1

Hello. Thank you for your opentracing-tutorials. I tried to exercise codes of java, and found some misprints in documents. They are simple problems, so I fixed them. Also, I added...

snowdeer

Lesson 1 - path to Hello.java is wrong

1

It says `lesson01/exercise/Hello.java`, but should be `exercise/Hello.java` (relative to the "current lesson"), so that the file is created at `src/main/java/lesson01/exercise/Hello.java`, relative to the tutorial root

jpkrohling

set_tag is not updating tags and duration

8

New to opentracing, Try to explore opentracing and jaeger UI. After gone through the lessons, With help of lesson01 solution [https://github.com/yurishkuro/opentracing-tutorial/tree/master/python/lesson01/solution](url) tried to include some logic with sleep to add...

dhineshmm

FlaskTracer vs opentracing.tracer

1

https://github.com/yurishkuro/opentracing-tutorial/blob/master/python/lesson03/solution/formatter.py#L12 fails if tracer is FlaskTracer with `'FlaskTracer' object has no attribute '_noop_span_context'`. Could we add some distinction between the two tracer objects?

ror6ax

Edit nodejs tutorial

2

The nodejs tutorial should more closely match the python tutorial, which is excellent. See [WIP](https://github.com/yurishkuro/opentracing-tutorial/pull/6).

MarckK