pytest-sanic
pytest-sanic copied to clipboard
fix Signal issue with Sanic 21.9
Proposed Changes
- fix https://github.com/yunstanford/pytest-sanic/issues/61
Should I also update poetry.lock
? We might also wanna double check if this actually works with older Sanic versions
I've ported this fix to https://github.com/yunstanford/pytest-sanic/pull/66 and added the changes mentioned in the issue
@ancalita @melindaloubser1 there is also an official test library for Sanic (https://sanic.dev/en/plugins/sanic-testing/getting-started.html) which I’d recommend to use instead of pytest-sanic. I switched out the Rasa X code with that one and it was relatively straight forward if I remember correctly
Thanks for the tip @wochinge 🙏
@yunstanford do you think this can be merged? This prevents people from using current sanic versions :)