pytest-sanic icon indicating copy to clipboard operation
pytest-sanic copied to clipboard

fix Signal issue with Sanic 21.9

Open wochinge opened this issue 2 years ago • 4 comments

Proposed Changes

  • fix https://github.com/yunstanford/pytest-sanic/issues/61

wochinge avatar Nov 05 '21 09:11 wochinge

Should I also update poetry.lock? We might also wanna double check if this actually works with older Sanic versions

wochinge avatar Nov 05 '21 09:11 wochinge

I've ported this fix to https://github.com/yunstanford/pytest-sanic/pull/66 and added the changes mentioned in the issue

indam23 avatar Jul 01 '22 13:07 indam23

@ancalita @melindaloubser1 there is also an official test library for Sanic (https://sanic.dev/en/plugins/sanic-testing/getting-started.html) which I’d recommend to use instead of pytest-sanic. I switched out the Rasa X code with that one and it was relatively straight forward if I remember correctly

wochinge avatar Jul 01 '22 14:07 wochinge

Thanks for the tip @wochinge 🙏

indam23 avatar Jul 04 '22 08:07 indam23

@yunstanford do you think this can be merged? This prevents people from using current sanic versions :)

ottonemo avatar Oct 21 '22 09:10 ottonemo