SmartTube icon indicating copy to clipboard operation
SmartTube copied to clipboard

[BUG] Hide played items from playlist broken

Open chuckkay opened this issue 1 year ago • 2 comments

Checklist

  • [X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • [X] I have read the FAQ and my problem isn't listed.
  • [X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • [X] This issue contains only one bug.

Affected version

23.88

Device Type

Smart TV/Box

Affected Android

Firetv tv

Steps to reproduce the bug

Add videos to watch later playlist, watch some videos, leave playlist and come back

Actual behavior

watched videos are still in the platlist even with a full red progress bar under the watched videos

Additional information

Its Been happening for the past 2 weeks

chuckkay avatar Sep 30 '24 21:09 chuckkay

Bump, am I alone with this issue?

chuckkay avatar Oct 02 '24 01:10 chuckkay

me as well - nvidia shield - been like this for ages, very frustrating

rguenther1209 avatar Oct 08 '24 20:10 rguenther1209

I see this as well, the described bug is in https://github.com/yuliskov/SmartTube/issues/3758 too.

AndrewGable avatar Oct 27 '24 22:10 AndrewGable

Seems like it's this line, https://github.com/yuliskov/SmartTube/blob/master/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoStateController.java#L622

Asked in Telegram for help on how to build as gradle sync isn't working on the latest Android Studio.

AndrewGable avatar Oct 27 '24 22:10 AndrewGable

Your reproduction steps don't say anything about removing the video after watching it. Are you expected it to remove automatically after watching?

retrocaster avatar Oct 27 '24 23:10 retrocaster

Also wanted to note that removing a video from "watch later" playlist manually works, so ideally we could re-use that logic for the automatic removing.

AndrewGable avatar Oct 27 '24 23:10 AndrewGable

Are you expected it to remove automatically after watching?

Yes I would expect this when the "Hide watched videos from Watch later playlist" setting is turned "ON".

Currently, watched videos are removed from the Watch later playlist once you navigate away from the watch later playlist and return. I would expect them to be removed without needing to navigate out of the playlist.

AndrewGable avatar Oct 27 '24 23:10 AndrewGable

yea thats what the option says 'hide unwanted content' i founf for it to work well i had to keep cache clean

On Sun., Oct. 27, 2024, 5:34 p.m. retrocaster, @.***> wrote:

Your reproduction steps don't say anything about removing the video after watching it. Are you expected it to remove automatically after watching?

— Reply to this email directly, view it on GitHub https://github.com/yuliskov/SmartTube/issues/3955#issuecomment-2440219625, or unsubscribe https://github.com/notifications/unsubscribe-auth/BH463VL5RTNBDCJPWIDRAJLZ5V2BHAVCNFSM6AAAAABPEITTJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGIYTSNRSGU . You are receiving this because you commented.Message ID: @.***>

rguenther1209 avatar Oct 27 '24 23:10 rguenther1209