pushing icon indicating copy to clipboard operation
pushing copied to clipboard

Why disabled relative path?

Open chatii opened this issue 5 years ago • 2 comments

https://github.com/yuki24/pushing/blob/3fecf175b8f3a5aad6bc93698acd2e6d1cc47a5f/lib/pushing/base.rb#L105-L108

For Web Push, for example, an icon can specify a path like "/assets/icon.png" and it works. Unlike mail (ActionMailer), relative path is accepted, so I think it should be enabled.

chatii avatar Mar 20 '19 10:03 chatii

Oh interesting, I was not aware of the fact that relative paths could be sent. I'll have to familiarize myself with Web Push though (I've only used APN and FCM), but I'd be happy to add better support for Web Push as well.

For now you could jut override the #supports_path? method to work around it:

class ApplicationNotifier < Pushing::Base
  def self. supports_path?
    true
  end
end

yuki24 avatar Mar 27 '19 03:03 yuki24

@yuki24 Thanks for you reply! I try override #supports_path? method, and I expect to your code 👍

chatii avatar Mar 29 '19 06:03 chatii