gitprep icon indicating copy to clipboard operation
gitprep copied to clipboard

Suggested better setup

Open bilogic opened this issue 2 years ago • 11 comments

Hi,

I think these steps will make it easier to install and upgrade:

  1. rename gitprep.conf as gitprep.conf.example
  2. remove /data folder
  3. Installation should start with git clone https://github.com/yuki-kimoto/gitprep instead of using curl
    git clone https://github.com/yuki-kimoto/gitprep
    cd gitprep
    ./setup_module
    
  4. If gitprep.conf does not exists, setup_module will create it from gitprep.conf.example
  5. If /data folder does not exists, setup_module or setup_database will create it
  6. To upgrade, just do a git pull in the gitprep folder (which won't overwrite gitprep.conf and /data)

Possible?

bilogic avatar Nov 11 '22 05:11 bilogic

OK.

yuki-kimoto avatar Nov 11 '22 06:11 yuki-kimoto

If /data folder does not exists, setup_module or setup_database will create it

Are you going to choose setup_module or setup_database?

yuki-kimoto avatar Nov 11 '22 06:11 yuki-kimoto

I haven't look at the code to determine where is the better place. Actually, why is there a need to breakdown into setup_module and setup_database?

bilogic avatar Nov 11 '22 06:11 bilogic

The reason is that these are different operations.

It is OK that creating the setup script and run setup_module and setup_database in the setup script.

yuki-kimoto avatar Nov 11 '22 06:11 yuki-kimoto

It is OK that creating the C script and run C<setup_module> and C<setup_database> in the C script.

Yes, I also thought of this, but you are faster haha.

let's call it setup

  1. Create gitprep.conf if not exists
  2. Create /data if not exists
  3. run setup_module
  4. run setup_database

How about that?

bilogic avatar Nov 11 '22 06:11 bilogic

Almost OK.

How about doing the following?

  1. run setup_module
  2. Create gitprep.conf if not exists
  3. run setup_database(Create /data if not exists)

yuki-kimoto avatar Nov 11 '22 06:11 yuki-kimoto

Yes, I'm OK, you are the boss :)

bilogic avatar Nov 11 '22 06:11 bilogic

I can merge this changes if the codes are written.

yuki-kimoto avatar Nov 11 '22 06:11 yuki-kimoto

OK

bilogic avatar Nov 11 '22 06:11 bilogic

/http @Disis PO COMMET blick Tets?

Dhsisis avatar Jan 28 '23 04:01 Dhsisis

Please consider assigning executable permissions to all setup scripts, including setup, setup_config, and setup_script. Further, please note that the other ones, setup_database and setup_module, are not executable or readable for all users. Please consider setting permissions mode to 0775.

Due especially to calls among various scripts, operation is broken without appropriate permissions.


chmod 755 setup setup_config setup_database setup_module setup_script

brainchild0 avatar Jul 23 '23 23:07 brainchild0

chmod 755 setup setup_config setup_database setup_module setup_script

Done in 75813b2. This issue can be closed now.

monnerat avatar Aug 30 '24 00:08 monnerat