Yuya Nishihara

Results 132 comments of Yuya Nishihara

> will try to reimplement the FTP mode for your batch solution I suggest benchmarking batched FTP before implementing it seriously. If the performance improvement isn't significant, including FTP mode...

It doesn't look correct to enforce the encoding of the process I/O. Maybe we'll need to translate serr back to a unicode string. (or simply use `%r` instead of `%s`...

Well, the hashed filename is the cache key to avoid running plantuml unless necessary. Running plantuml is painfully slow. Perhaps, you can instead *copy* (or symlink) a generated file to...

Windows batch file runs quite differently than a normal command. You'll probably need to specify `plantuml = ['cmd.exe', '/c', path_to_batch_file]`, or simply embed the batchfile content into `plantuml = [...]`.

> could be done in Unix to specify plantuml Yep, Unix shell scripts can work exactly in the same semantics as compiled executables. > if there is a way to...

Patches are welcome. Perhaps it will need a trick to make UML images compatible with the images extension since we wouldn't want to duplicate codes to support a modern zooming...

Isn't it annoying that you find exactly the same image of the same size is displayed by clicking it?

I didn't know `max-width: 100%` is set by the default style. That's why I thought inserting `` is useless. That said, neither the Sphinx core nor the graphviz extension appears...

@alexfargus I'm not an expert of sphinx, but your approach looks way nicer than the current node substitution logic, which is based off the graphviz extension in sphinx 0.9 era....

Maybe you can control the appearance with css, `.plantuml { display: inline }` for example. Adding option to use `` (or remove `` at all) is fine, but I don't...