gopher-lua icon indicating copy to clipboard operation
gopher-lua copied to clipboard

library gopherlua-debugger need some dependency

Open edolphin-ydf opened this issue 5 years ago • 3 comments

I'v made the lib gopherlua-debugger. But it need modify some code in gopher-lua

  1. #131 this pr is needed which make gopher-lua support the hook feature.
  2. some fix in the first pr, include import error and SetHook fix hook fix
  3. #252 a bug in gopher-lua. I'v tried to fix it in my fork getlocal buf fix. I could make a pr if needed.

A debugger is very useful sometimes. Hope to finish this work together.

edolphin-ydf avatar Dec 15 '19 08:12 edolphin-ydf

@edolphin-ydf Does this affect the performance when not using debug.sethook? If yes, how much?

epikur-io avatar Dec 18 '19 09:12 epikur-io

@epikur-io I didn't create or run a benckmark with this. And the main affect to performance is based on #131 which should be discuss in #130 . What i'v done with gopher-lua is just add a little memeory usage to store some infomation about source code. So the affect to performance can be ignored when not using debug.sethook.

edolphin-ydf avatar Dec 18 '19 09:12 edolphin-ydf

@edolphin-ydf Sorry now I can not spend much time for this project. I've planed to implement Lua5.3 spec but I decided to terminate this task(#161). In #161 I implemented goto statements.

I am going to merge this changes into main branch. It is preferable that making any large changes are occurs after this merge.

yuin avatar Dec 20 '19 02:12 yuin