goldmark

goldmark copied to clipboard

Improve thematic break

1

I was writing a custom thematic break parser for a side project and noticed that the original contains a typographical error. I fixed the error. I also added a few...

dkotik

change: Export render functions

2

Exports all render* functions, as suggested in https://github.com/yuin/goldmark/discussions/414 This will make it easier to reuse goldmark with custom renderers.

mrueg

update unsafe code to user newer-faster-better idioms

1

The new unsafe string/slice functions insulate the code from unlikely-but-still-possible changes to string and slice representation, and tend to compile to slightly better code. Build tags keep things working with...

dr2chase

Footnote in a footnote appears before other footnotes

6

goldmark has [https://github.com/yuin/goldmark/discussions](Discussions) in github. You should post only issues here. Feature requests and questions should be posted at discussions. - [ ] goldmark is fully compliant with the CommonMark....

kuruczgy

Single quotes not opening before the letter 't'

4

goldmark has [https://github.com/yuin/goldmark/discussions](Discussions) in github. You should post only issues here. Feature requests and questions should be posted at discussions. - [x] goldmark is fully compliant with the CommonMark. Before...

cl1ntv

Bad href attribute when linkify and typographer extensions are enabled

6

What version of goldmark are you using? : 1.5.2 What version of Go are you using? : 1.19.3 What operating system and processor architecture are you using? : linux/amd64 code...

jmooring

Trying this here, as I haven't received a response on this https://github.com/yuin/goldmark/pull/425 This would match https://github.com/yuin/goldmark/blob/90c46e0829c11ca8d1010856b2a6f6f88bfc68a3/ast/inline.go#L115 and https://github.com/yuin/goldmark/blob/90c46e0829c11ca8d1010856b2a6f6f88bfc68a3/ast/inline.go#L85

mrueg

hezhizhen

Spec says: > A [*line*](https://spec.commonmark.org/0.31.2/#line) *is a sequence of zero* or more [*characters*](https://spec.commonmark.org/0.31.2/#character) other than line feed (U+000A) or carriage return (U+000D), *followed by* a [line ending](https://spec.commonmark.org/0.31.2/#line-ending) or by *the...

Andrew-Morozko

Failing example ```md - - foo ``` commonmark: ```html foo ``` goldmark: ```html foo ``` [commonmark](https://spec.commonmark.org/dingus/?text=-%20%0A%20%20-%20foo) vs [goldmark](https://yuin.github.io/goldmark/playground/?m=-%20%0A%20%20-%20foo&o=0&v=v1.7.4) [This check](https://github.com/yuin/goldmark/blob/15ade8aace9a9f269846fb83d36fc7bcec875cd5/parser/list_item.go#L43) seems to be the culprit

Andrew-Morozko