[DocDB] Master metric 'is_load_balancing_enabled' displays inconsistent statistic value

[fritshoogland-yugabyte]

Jira Link: DB-3153

Description

In version 2.15.2.0-b83, when using the /metrics endpoint for the master server, the statistic is_load_balancing_enabled shows the value: false.

However, the values for name/value combinations are always numeric, and therefore is inconsistent with other name/value statistics.

This is an excerpt from the /metrics page:

        "type": "cluster",
        "id": "yb.cluster",
        "attributes": {},
        "metrics": [
            {
                "name": "is_load_balancing_enabled",
                "value": false
            }

In general false should be '0' and true should be '1'.

[bmatican]

Hey @msun07 , hopefully small tweak to your recent work to add this metric -- let's make it a 0/1 metric, rather than true/false

I honestly didn't even know it's possible to setup a boolean metric, but I suspect some of our tooling would not be prepared for that.

[msun07]

Right, even for the is_raft_leader_metric_, we use a numeric metric. Is "cluster" the right type for this metric? @fritshoogland-yugabyte @bmatican

[bmatican]

@msun07 I don't think we use many cluster type metrics, so a-ok to have this be server and we can standardize on tablet/table/server.

The problem here is more METRIC_DEFINE_gauge_bool so bool instead of int

[fritshoogland-yugabyte]

Yes, the name/value combinations always show a numeric value, like is_raft_leader. I cannot answer the question about type.

Frits Hoogland | Developer Advocate Mobile: +31-6-14180860 https://www.yugabyte.com

On 11 Aug 2022, at 17:43, Mingda Sun @.***> wrote:

Right, even for the is_raft_leader_metric_, we use a numeric metric. Is "cluster" the right type for this metric? @fritshoogland-yugabyte https://www.google.com/url?q=https://github.com/fritshoogland-yugabyte&source=gmail-imap&ust=1660837407000000&usg=AOvVaw2fuGbOG00u1ZXXodpLcrzY @bmatican https://www.google.com/url?q=https://github.com/bmatican&source=gmail-imap&ust=1660837407000000&usg=AOvVaw28qlCQ-Q1TaN5aQMB-tuhd — Reply to this email directly, view it on GitHub https://www.google.com/url?q=https://github.com/yugabyte/yugabyte-db/issues/13574%23issuecomment-1212164437&source=gmail-imap&ust=1660837407000000&usg=AOvVaw2-bPznENuvRkwbid9WEQjV, or unsubscribe https://www.google.com/url?q=https://github.com/notifications/unsubscribe-auth/ATP5QQQKIUUBMIZ672YX46LVYUNR3ANCNFSM56IIBI3A&source=gmail-imap&ust=1660837407000000&usg=AOvVaw18dlqNZm7H_KnBSUTwbNI5. You are receiving this because you were mentioned.