charts
charts copied to clipboard
added value overrides for master broadcastaddress
FOR GKE MCS support. GKE MCS will need the override of server_broadcast_addresses.
+1. Just like the tservers, the masters need to be able to set the broadcast address. Small nit: this should be in the values file as well.
While I support this change, I'm trying to understand how do we plan to use it for GKE MCS.
When we set a value of master.serverBroadcastAddresses
, the same value is passed to all the master pods created by the chart release. So, we will have to specifically set it for each release in each region/AZ to something like $(HOSTNAME).us-east-a.yb-masters.us-east-a-ns.svc.clusterset.local
.
Other option is to keep the broadcast address unchanged and use masterAddresses like this: {<service name global across clusters - master-0>, <service name local to the cluster - master-0>}, {yb-master-1.us-east-a.yb-masters.ans.svc.clusterset.local,yb-master-1.yb-masters.ans.svc.cluster.local}...
.
This format makes it possible to tell TServer and Masters that each master has two ways to reach it. Need to test if this method works with GKE MCS though, that is something similar which we used for Istio multi-cluster setup. https://gist.github.com/bhavin192/ad3e0a7be5e23c00784fca864db9e1fc