Vuejs 2.0 Migration

[Humeira]

I have started working on migrating vue-strap to vue 2.0, I'll be grateful if someone can create a new branch v2 here.

Some folks have show interest in migrating to 2.0 as well https://github.com/yuche/vue-strap/issues/372 https://github.com/yuche/vue-strap/issues/374

[purepear]

I just found today this one for vue 2 and bootstrap 4 https://github.com/pi0/bootstrap-vue I haven't tested it properly yet cause it's tricky to run it with vueify and without scss.. but i think if you use webpack it's good to go

[Humeira]

@purepear Yes it kind of have the same thing as vue-strap. But, vue-strap has more users I reckon it will be a really idea to start migrating this one, than moving to another completely different repo.

[Humeira]

@wffranco Hello is it possible for you to create a new branch v2 on this repo?

[yuche]

@Humeira done.

[Humeira]

@yuche cool thanks!

[wffranco]

Well, i done a vue2 branch and started the migration, not finished yet. https://github.com/wffranco/vue-strap/tree/vue2

incomplete the documentation.

[Humeira]

@wffranco can you merge to the new branch v2 with a comment of what you have done, so that we are both not working on same components.

[wffranco]

yep when i finish the migration i do the merge :smile:

[Humeira]

@wffranco you have already done most part? 🤔 i just started doing the same thing.

[psi-4ward]

so we should probably make it more transparent and list alle components in the first comment of this issue and track the progress here.

[wffranco]

I migrated all the components, but had a lot of errors in the documentation, the first one I don't understand it...

I maybe will test the components apart of the project, to know if they work right.

If you can help me to detect what happen with the docs I will appreciate your help.

[Humeira]

@wffranco where can i get your changes?

[druppy]

@wffranco I have cloned you repos, and it build nicely locally, but then i tried the vue-migration-helper, and it came up with 166 errors.

Especially all the errors related to coerce properties and twoWayneed some attention.

The Datepicker.vue has this dispatch error.

If we could find a common solution for these errors, then it is just a question of fixing the Components one at a time (make a list and spit it in 3 ?). Is it possible to work directly on your fork somehow ?

[wffranco]

Sorry I'm really busy with 2 projects, so I have no time to continue the migration right now. @druppy I run the migration helper 3 days ago in src and fix all the errors, let me check if I forgot to push the last changes.

Edit: Nope, I check and I do the last commit 2 days ago and have no migration errors, I fix all that things, even the dispatch errors... maybe need some extra adjustment for a better working, but not related with migration errors.

[ropeladder]

Can confirm that the src directory of the vue2 branch on wffranco's fork returns no errors. I'm getting a build error though because for some reason ButtonGroup.vue got renamed to buttonGroup.vue; otherwise it seems to build fine.

[purepear]

@ropeladder haven't tried it yet but might be a linux/mac/windows - uppercase/lowercase filesystem thing

[wffranco]

I think the best option is testing the components individually, maybe in a clean window... But like I said I have no time right now.

[druppy]

@wffranco Nice work !, please let me know where to get these changes, or when you have time to commit it onto the fork. I have cloned your fork, so I can test it from there.

@ropeladder how did you test that ? I still get 166 errors from the vue-migration-helper tool :-)

[ropeladder]

@druppy Just like this:

git clone https://github.com/wffranco/vue-strap.git
cd vue-strap
git checkout vue2
cd src
vue-migration-helper

[wffranco]

@ropeladder you right I renamed the buttongroup, now match with the standard in the project. But the real problem is that I comment almost all the documentation files and still not working... so I think that need to be tested one by one.

[druppy]

@ropeladder Sorry, I still need to work at my black belt as git ninja :-) git will not checkout isdist has some build js files ... sight.

So, time to test components ... thanks !

[ropeladder]

I'm trying out dropdowns and they appear to work correctly, but Vue gives a warning that they should not be mutating the value property. I don't really understand well enough how the component is built to know what the correct way to refactor would be.

[wffranco]

well, I needed select component so I fix it and fixed the helpers for supporting of laravel 5.3 (give some errors because this uses buble-loader to convert ES2015 and have some limitations).

nobody else have working over my branch? if somebody want to help just tell me or make a push request if you're done something.

Here the branch again if somebody need it: https://github.com/wffranco/vue-strap/tree/vue2

[wffranco]

According to vue2, twoway binding is not supported, except for v-model. But I think on a simple feature to make a twoway binding for any property, compatible with vue 1 and 2, but not tested yet.

[druppy]

@wffranco I have just tried to fix a few build docs errors, but I have no access to the branch :-)

ERROR: Permission to wffranco/vue-strap.git denied to druppy.

[wffranco]

make a pull request? anyway, let me see if I can add you :stuck_out_tongue: EDIT: done, try again.

[druppy]

Yes, thanks ... tried some small changes, time for some more work, now that it is not in vain :-)

Any reason for dist and build content to be added to the repos, git complains about it after a re-build.

[wffranco]

• fixed Input
• fixed select
• formGroup will be renamed to formValidator, the formGroup component will have another purpose
• reordering components for a better control of the fixes

By for now I only will fix the components I need, have a lot of work, but need some components in vue 2 (the documentation are not working, so I test and fix the components in another project).

Next to fix:

• tabs
• tabGroup
• tab
• dropdown

[webnoob]

@wffranco Is there a way to see everything that has been ported to vue2 and what is left outstanding?

I'd like to start using this in my project but need to know what's available (and I might be able to help with the migration for the bits I need personally).

Also, with regards to using the Vue2 version, how do we go about that, just npm install vue-sharp as normal or is there a special version we should be installing?

[Humeira]

@webnoob It's still a work in progress. You can find the changes on @wffranco branch vue2. If you want to see vue-strap with vue.js 2.x, just switch to that branch and do a npm install. Everything already in the package.json.