vdx icon indicating copy to clipboard operation
vdx copied to clipboard

Dockerfile

Open letompouce opened this issue 4 years ago • 3 comments

This PR add a (simple) Dockerfile for people who don't want to install NodeJs locally.

letompouce avatar Nov 01 '20 16:11 letompouce

I would probably add a section in the docs about running with a Dockerfile if this gets merged, so maybe would be cool to add that as part of this PR.

deadpyxel avatar Nov 02 '20 13:11 deadpyxel

I would probably add a section in the docs about running with a Dockerfile if this gets merged, so maybe would be cool to add that as part of this PR.

Like in... https://github.com/yuanqing/vdx/pull/8/commits/fac67f84b05055c0ec88228f827a0dc39e518dd1#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R189-R204 ? Or did I miss something?

letompouce avatar Nov 03 '20 08:11 letompouce

Yes, that was the idea, good job.

deadpyxel avatar Nov 03 '20 19:11 deadpyxel